Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: net/cert/ct_known_logs.h

Issue 337603003: Certificate Transparency: Switch to using a generated CT log list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_known_logs.h
diff --git a/net/cert/ct_known_logs.h b/net/cert/ct_known_logs.h
index d616e9b358c0f843a092739e87df3f5df178fe3b..733fa50c86a85f3e51c7387685e2cac39e3928ae 100644
--- a/net/cert/ct_known_logs.h
+++ b/net/cert/ct_known_logs.h
@@ -5,7 +5,9 @@
#ifndef NET_CERT_CT_KNOWN_LOGS_H_
#define NET_CERT_CT_KNOWN_LOGS_H_
-#include "base/memory/scoped_ptr.h"
+#include <vector>
+
+#include "base/memory/linked_ptr.h"
#include "net/base/net_export.h"
namespace net {
@@ -14,14 +16,9 @@ class CTLogVerifier;
namespace ct {
-// Creates a CTLogVerifier instance for the Google Pilot CT Log
-NET_EXPORT scoped_ptr<CTLogVerifier> CreateGooglePilotLogVerifier();
-
-// Creates a CTLogVerifier instance for the Google "Aviator" Log
-NET_EXPORT scoped_ptr<CTLogVerifier> CreateGoogleAviatorLogVerifier();
-
-// Creates a CTLogVerifier instance for the Google "Rocketeer" Log
-NET_EXPORT scoped_ptr<CTLogVerifier> CreateGoogleRocketeerLogVerifier();
+// Meant to be consumed by the caller.
agl 2014/06/13 00:32:05 // CreateLogVerifiersForKnownLogs returns a vector
Ryan Sleevi 2014/06/17 01:02:03 This comment doesn't really provide any descriptio
Eran Messeri 2014/06/17 17:31:41 Done.
Eran Messeri 2014/06/17 17:31:41 Done.
+NET_EXPORT std::vector<linked_ptr<CTLogVerifier> >
Ryan Sleevi 2014/06/17 01:02:03 Use ScopedVector instead - https://code.google.com
Eran Messeri 2014/06/17 17:31:41 Done.
+ CreateLogVerifiersForKnownLogs();
Ryan Sleevi 2014/06/17 01:02:04 four spaces
Eran Messeri 2014/06/17 17:31:41 Done.
} // namespace ct

Powered by Google App Engine
This is Rietveld 408576698