Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 337603002: Revert of Telemetry: Build symfs for Android VTune profiler (Closed)

Created:
6 years, 6 months ago by achuithb
Modified:
6 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of Telemetry: Build symfs for Android VTune profiler (https://codereview.chromium.org/308123002/) Reason for revert: This breaks ChromeOS build at http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29... 16:09:25 INFO | autoserv| FAIL login_Cryptohome login_Cryptohome timestamp=1402607364 localtime=Jun 12 14:09:24 Unhandled ImportError: No module named sqlite3 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: Traceback (most recent call last): 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: File "/usr/local/autotest/common_lib/test.py", line 725, in _call_test_function 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: return func(*args, **dargs) ... 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: File "/usr/local/telemetry/src/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py", line 12, in <module> 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: import sqlite3 16:09:25 INFO | autoserv| AUTOTEST_STATUS:: ImportError: No module named sqlite3 ChromeOS image does not have sqlite3. Please either file a bug (cc vapier@) to add sqlite3. Or skip the sqlite3 logic for chromeos. I suggest to revert this for now so that it does not shadow other failures. Please use cbuildbot --remote -G <rietveld_id> x86-generic-tot-chrome-pfq-informational amd64-generic-tot-chrome-pfq-informational daisy-tot-chrome-pfq-informational to ensure the CL runs fine on ChromeOS when landing the new version. Original issue's description: > Telemetry: Build symfs for Android VTune profiler > > Extend and use android_profiling_helper.py to set up a symfs for VTune. > Queries the required libraries from the profiler's output and pulls them from > the device. This allows VTune to resolve all symbols in the profiling output. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276740 TBR=skyostil@chromium.org,simonhatch@chromium.org,tonyg@chromium.org,xiyuan@chromium.org,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -400 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 2 chunks +0 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 2 chunks +0 lines, -32 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py View 3 chunks +15 lines, -30 lines 0 comments Download
D tools/telemetry/unittest_data/sample_vtune_db_output View 1 chunk +0 lines, -316 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
achuithb
Created Revert of Telemetry: Build symfs for Android VTune profiler
6 years, 6 months ago (2014-06-12 22:41:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/337603002/1
6 years, 6 months ago (2014-06-12 22:43:00 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:46:59 UTC) #3
Message was sent while issue was closed.
Change committed as 276836

Powered by Google App Engine
This is Rietveld 408576698