Issue 337563002: Launcher flow

Issue 337563002: Launcher flow (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Launcher flow R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276892

Patch Set 4 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -2 lines)			Patch
M	mojo/aura/window_tree_host_mojo.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/examples/browser/browser.cc	View		3 chunks	+21 lines, -1 line	0 comments	Download
A	mojo/examples/html_viewer/html_viewer.cc	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/mojo_examples.gypi	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	mojo/services/launcher/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	mojo/services/launcher/launcher.cc	View	1 2 3	1 chunk	+160 lines, -0 lines	0 comments	Download
A	mojo/services/public/interfaces/launcher/launcher.mojom	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Simple hand-wavy launcher flow. I'll add a view to this next.

6 years, 6 months ago (2014-06-12 21:31:51 UTC) #1

sky

LGTM https://codereview.chromium.org/337563002/diff/40001/mojo/mojo.gyp File mojo/mojo.gyp (right): https://codereview.chromium.org/337563002/diff/40001/mojo/mojo.gyp#newcode40 mojo/mojo.gyp:40: 'mojo_html_viewer', nit: sort

6 years, 6 months ago (2014-06-12 21:35:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/337563002/60001

6 years, 6 months ago (2014-06-12 23:29:16 UTC) #4

Ben Goodger (Google)

6 years, 6 months ago (2014-06-13 02:32:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r276892 (presubmit successful).

Expand Messages | Collapse Messages