Issue 337543005: Fix crash if legacy hwnd is NULL on win 8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337543005: Fix crash if legacy hwnd is NULL on win 8. (Closed)

Created:
6 years, 6 months ago by dmazzoni

Modified:
6 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash if legacy hwnd is NULL on win 8. Change r276950 (https://codereview.chromium.org/329053004/) fixed a bug but introduced a new crash on win 8 by not checking the legacy hwnd for NULL. BUG=384732, 372478, 379019 TBR=ananta Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277319

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	content/browser/accessibility/browser_accessibility_manager_win.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/337543005/1

6 years, 6 months ago (2014-06-15 07:39:47 UTC) #5

Message was sent while issue was closed.

Change committed as 277319

Expand Messages | Collapse Messages