Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: chrome/browser/ui/webui/options/font_settings_browsertest.js

Issue 33753004: Add link to the Advanced Font Settings extension in Font Settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/font_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/options/font_settings_browsertest.js b/chrome/browser/ui/webui/options/font_settings_browsertest.js
index f3da8dc13749985f0c003b35282abce7083b167e..68998589c9d9aef285bc3b6474037066eebe4632 100644
--- a/chrome/browser/ui/webui/options/font_settings_browsertest.js
+++ b/chrome/browser/ui/webui/options/font_settings_browsertest.js
@@ -16,9 +16,33 @@ FontSettingsWebUITest.prototype = {
* Browse to the font settings page.
**/
browsePreload: 'chrome://settings-frame/fonts',
+
+ /** @inheritDoc */
+ preLoad: function() {
+ this.makeAndRegisterMockHandler(['openAdvancedFontSettingsOptions']);
+ }
};
// Test opening font settings has correct location.
TEST_F('FontSettingsWebUITest', 'testOpenFontSettings', function() {
assertEquals(this.browsePreload, document.location.href);
});
+
+// Test setup of the Advanced Font Settings links.
+TEST_F('FontSettingsWebUITest', 'testAdvancedFontSettingsLink', function() {
+ var installElement = $('advanced-font-settings-install');
+ var optionsElement = $('advanced-font-settings-options');
+ var expectedUrl = 'https://chrome.google.com/webstore/detail/' +
+ 'caclkomlalccbpcdllchkeecicepbmbm';
+
+ FontSettings.notifyAdvancedFontSettingsAvailability(false);
+ assertFalse(installElement.hidden);
+ assertEquals(expectedUrl, installElement.querySelector('a').href);
+ assertTrue(optionsElement.hidden);
+
+ FontSettings.notifyAdvancedFontSettingsAvailability(true);
+ assertTrue(installElement.hidden);
+ assertFalse(optionsElement.hidden);
+ this.mockHandler.expects(once()).openAdvancedFontSettingsOptions();
+ optionsElement.click();
+});

Powered by Google App Engine
This is Rietveld 408576698