Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 33753003: Removed unhanled/unused Blink API implementation for SharedWorker (Closed)

Created:
7 years, 2 months ago by kinuko
Modified:
7 years, 2 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Removed unhanled/unused Blink API implementation for SharedWorker Corresponding to the blink's cleanup change: https://src.chromium.org/viewvc/blink?revision=160281&view=revision BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M content/common/worker_messages.h View 1 chunk +0 lines, -14 lines 0 comments Download
M content/worker/websharedworkerclient_proxy.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/worker/websharedworkerclient_proxy.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
Code removal only. PTL content/*: jam content/common/worker_messages.h: tsepez
7 years, 2 months ago (2013-10-23 04:39:45 UTC) #1
Tom Sepez
Rubberstamp LGTM on removing code. Thanks for the cleanup!
7 years, 2 months ago (2013-10-23 16:53:26 UTC) #2
jam
lgtm
7 years, 2 months ago (2013-10-24 00:08:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/33753003/1
7 years, 2 months ago (2013-10-24 03:08:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=92622
7 years, 2 months ago (2013-10-24 07:28:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/33753003/1
7 years, 2 months ago (2013-10-24 11:25:33 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 17:10:43 UTC) #7
Message was sent while issue was closed.
Change committed as 230747

Powered by Google App Engine
This is Rietveld 408576698