Sooper experimental refactoring of the profile info cache.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 56 matching lines @@
   NUM_PROFILE_AVATAR_METRICS
 };
 
 void ProfileMetrics::LogNumberOfProfiles(ProfileManager* manager) {
   const ProfileInfoCache& info_cache = manager->GetProfileInfoCache();
   size_t number_of_profiles = info_cache.GetNumberOfProfiles();
   UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfProfiles",
                             number_of_profiles);
 
   // Ignore other metrics if we have no profiles, e.g. in Chrome Frame tests.
-  if (number_of_profiles) {
-    size_t number_of_managed_profiles = 0;
-    size_t number_of_signed_in_profiles = 0;
-    for (size_t i = 0; i < number_of_profiles; ++i) {
-      if (info_cache.ProfileIsManagedAtIndex(i))
-        ++number_of_managed_profiles;
-      if (!info_cache.GetUserNameOfProfileAtIndex(i).empty())
-        ++number_of_signed_in_profiles;
-    }
-    UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfManagedProfiles",
-                              number_of_managed_profiles);
-    UMA_HISTOGRAM_COUNTS_100("Profile.PercentageOfManagedProfiles",
-        100 * number_of_managed_profiles / number_of_profiles);
-    UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSignedInProfiles",
-                              number_of_signed_in_profiles);
+  if (!number_of_profiles)
+    return;
+
+  size_t number_of_managed_profiles = 0;
+  size_t number_of_signed_in_profiles = 0;
+
+  const std::vector<ProfileInfoEntry> entries(info_cache.GetProfilesSortedByName());
+  for (std::vector<ProfileInfoEntry>::const_iterator it = entries.begin();
+      it != entries.end(); ++it) {
+    if (it->IsManaged())
+      ++number_of_managed_profiles;
+    if (!it->user_name().empty())
+      ++number_of_signed_in_profiles;
   }
+  UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfManagedProfiles",
+                            number_of_managed_profiles);
+  UMA_HISTOGRAM_COUNTS_100("Profile.PercentageOfManagedProfiles",
+      100 * number_of_managed_profiles / number_of_profiles);
+  UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSignedInProfiles",
+                            number_of_signed_in_profiles);
 }
 
 void ProfileMetrics::LogProfileAddNewUser(ProfileAdd metric) {
   DCHECK(metric < NUM_PROFILE_ADD_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.AddNewUser", metric,
                             NUM_PROFILE_ADD_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.NetUserCount", ADD_NEW_USER,
                             NUM_PROFILE_NET_METRICS);
 }
 
@@ skipping 138 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }