Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1627)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 337473010: Move implementation of WebFrameImpl::executeCommand to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2014-06-30T10:05:35 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 03a17e4291a42a38a598eb6315447ce66eea4a2f..5ef071365cb7b9caa30a9eba683b56a7c5c5070e 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1409,7 +1409,11 @@ bool WebViewImpl::scrollViewWithKeyboard(int keyCode, int modifiers)
#endif
if (!mapKeyCodeForScroll(keyCode, &scrollDirection, &scrollGranularity))
return false;
- return bubblingScroll(scrollDirection, scrollGranularity);
+
+ LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());
+ if (!frame)
+ return false;
+ return frame->eventHandler().bubblingScroll(scrollDirection, scrollGranularity);
}
bool WebViewImpl::mapKeyCodeForScroll(int keyCode,
@@ -1462,15 +1466,6 @@ void WebViewImpl::hideSelectPopup()
m_selectPopup->hidePopup();
}
-bool WebViewImpl::bubblingScroll(ScrollDirection scrollDirection, ScrollGranularity scrollGranularity)
-{
- LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());
- if (!frame)
- return false;
-
- return frame->eventHandler().bubblingScroll(scrollDirection, scrollGranularity);
-}
-
void WebViewImpl::popupOpened(PopupContainer* popupContainer)
{
ASSERT(!m_selectPopup);
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698