Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 337473010: Move implementation of WebFrameImpl::executeCommand to Editor (Closed)

Created:
6 years, 5 months ago by yosin_UTC9
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move implementation of WebFrameImpl::executeCommand to Editor This patch moves |WebFrameImpl::executeComamnd()| to |Editor| class to make "web" as thin API layer and ease of maintenance. This patch also get rid of |WebViewImpl::bubblingScroll|, which becomes unused function as result of moving |WebFrameImpl::executeCommand()|. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177179

Patch Set 1 : 2014-06-27T03:18:08 #

Total comments: 2

Patch Set 2 : 2014-06-30T10:05:35 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -48 lines) Patch
M Source/core/editing/Editor.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -34 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
6 years, 5 months ago (2014-06-27 09:07:24 UTC) #1
tkent
lgtm https://codereview.chromium.org/337473010/diff/20001/Source/core/editing/Editor.h File Source/core/editing/Editor.h (right): https://codereview.chromium.org/337473010/diff/20001/Source/core/editing/Editor.h#newcode158 Source/core/editing/Editor.h:158: bool executeCommand(const String&); We should have a comment ...
6 years, 5 months ago (2014-06-30 00:22:02 UTC) #2
yosin_UTC9
Thanks for reviewing! Committing... https://codereview.chromium.org/337473010/diff/20001/Source/core/editing/Editor.h File Source/core/editing/Editor.h (right): https://codereview.chromium.org/337473010/diff/20001/Source/core/editing/Editor.h#newcode158 Source/core/editing/Editor.h:158: bool executeCommand(const String&); On 2014/06/30 ...
6 years, 5 months ago (2014-06-30 01:22:08 UTC) #3
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 5 months ago (2014-06-30 01:22:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/337473010/40001
6 years, 5 months ago (2014-06-30 01:22:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 02:09:13 UTC) #6
Message was sent while issue was closed.
Change committed as 177179

Powered by Google App Engine
This is Rietveld 408576698