Refactor RenderBox::addVisualEffectOverflow()

Source/core/rendering/RenderBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 207 matching lines @@
     LayoutRect overflowRectForPaintRejection() const;
 
     LayoutRect contentsVisualOverflowRect() const { return m_overflow ? m_overflow->contentsVisualOverflowRect() : LayoutRect(); }
 
     void addLayoutOverflow(const LayoutRect&);
     void addVisualOverflow(const LayoutRect&);
 
     // Clipped by the contents clip, if one exists.
     void addContentsVisualOverflow(const LayoutRect&);
 
+    bool hasVisualEffectOverflow() const { return style()->boxShadow() || style()->hasBorderImageOutsets() || style()->hasOutline(); }

[Julien - ping for review, 2014/07/01 23:00:16]

https://codereview.chromium.org/204843002 landed which adds this function to
RenderStyle (where it belongs) so you will need to rebaseline the change.

[Xianzhu, 2014/07/02 00:02:03]

Done.

     void addVisualEffectOverflow();
+    LayoutBoxExtent computeVisualEffectOverflowExtent() const;
     void addOverflowFromChild(RenderBox* child) { addOverflowFromChild(child, child->locationOffset()); }
     void addOverflowFromChild(RenderBox* child, const LayoutSize& delta);
     void clearLayoutOverflow();
     void clearAllOverflows() { m_overflow.clear(); }
 
     void updateLayerTransformAfterLayout();
 
     LayoutUnit contentWidth() const { return clientWidth() - paddingLeft() - paddingRight(); }
     LayoutUnit contentHeight() const { return clientHeight() - paddingTop() - paddingBottom(); }
     LayoutUnit contentLogicalWidth() const { return style()->isHorizontalWritingMode() ? contentWidth() : contentHeight(); }
@@ skipping 534 matching lines @@
         if (UNLIKELY(inlineBoxWrapper() != 0))
             deleteLineBoxWrapper();
     }
 
     ensureRareData().m_inlineBoxWrapper = boxWrapper;
 }
 
 } // namespace WebCore
 
 #endif // RenderBox_h