Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337473007: Remove expensive workarounds for infra flakes from blink_trybot (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Remove expensive workarounds for infra flakes from blink_trybot BUG=385737, 357767 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -1912 lines) Patch
M scripts/slave/recipes/blink_trybot.py View 3 chunks +3 lines, -47 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/compile_failure_bot_update.json View 2 chunks +5 lines, -279 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/compile_failure_win.json View 3 chunks +34 lines, -387 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_bot_update_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_bot_update_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_compile_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_compile_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_no_bot_update_fail.json View 3 chunks +49 lines, -155 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_no_bot_update_pass.json View 2 chunks +31 lines, -91 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_linux_blink_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_compile_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_compile_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_mac_blink_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_no_bot_update_fail.json View 3 chunks +49 lines, -155 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_no_bot_update_pass.json View 2 chunks +31 lines, -91 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_v8_v8_linux_layout_dbg_fail.json View 3 chunks +46 lines, -154 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_v8_v8_linux_layout_dbg_pass.json View 2 chunks +28 lines, -91 lines 0 comments Download
D scripts/slave/recipes/blink_trybot.expected/gclient_revert_nuke.json View 1 chunk +0 lines, -425 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/minimal_pass_continues.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/preamble_test_failure.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/too_many_failures_for_retcode.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/webkit_tests_interrupted.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/webkit_tests_unexpected_error.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-26 23:19:58 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-26 23:26:23 UTC) #2
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-06-26 23:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/337473007/1
6 years, 6 months ago (2014-06-26 23:41:43 UTC) #4
commit-bot: I haz the power
Change committed as 280168
6 years, 6 months ago (2014-06-26 23:43:35 UTC) #5
Michael Achenbach
6 years, 5 months ago (2014-07-01 11:02:20 UTC) #6
Message was sent while issue was closed. 
Yet another CL with v8 expectations changes but nobody from v8 team was CC'ed.
Please do that in the future!

Some of the workarounds that got removed were needed for the v8 trybot which
doesn't work yet with bot_update. Now this trybot isn't working anymore...

Powered by Google App Engine
This is Rietveld 408576698