Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: components/nacl/common/nacl_types.cc

Issue 337463002: Remove LoadModule SRPC for non-SFI mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/common/nacl_types.cc
diff --git a/components/nacl/common/nacl_types.cc b/components/nacl/common/nacl_types.cc
index 0dc5a1cf312be215da7402ade1010a10f76395fa..67567efc73b48a8a7978fb6d58d580ae62e514f9 100644
--- a/components/nacl/common/nacl_types.cc
+++ b/components/nacl/common/nacl_types.cc
@@ -28,15 +28,22 @@ NaClLaunchParams::NaClLaunchParams()
enable_crash_throttling(false) {
Mark Seaborn 2014/06/17 00:50:31 This should initialise nexe_token_lo/hi too (but s
hidehiko 2014/06/18 08:43:32 Ack. Removed token_lo,hi.
}
-NaClLaunchParams::NaClLaunchParams(const std::string& manifest_url,
- int render_view_id,
- uint32 permission_bits,
- bool uses_irt,
- bool uses_nonsfi_mode,
- bool enable_dyncode_syscalls,
- bool enable_exception_handling,
- bool enable_crash_throttling)
+NaClLaunchParams::NaClLaunchParams(
+ const std::string& manifest_url,
+ const IPC::PlatformFileForTransit& nexe_file,
+ uint64_t nexe_token_lo,
+ uint64_t nexe_token_hi,
+ int render_view_id,
+ uint32 permission_bits,
+ bool uses_irt,
+ bool uses_nonsfi_mode,
+ bool enable_dyncode_syscalls,
+ bool enable_exception_handling,
+ bool enable_crash_throttling)
: manifest_url(manifest_url),
+ nexe_file(nexe_file),
+ nexe_token_lo(nexe_token_lo),
+ nexe_token_hi(nexe_token_hi),
render_view_id(render_view_id),
permission_bits(permission_bits),
uses_irt(uses_irt),
@@ -46,14 +53,18 @@ NaClLaunchParams::NaClLaunchParams(const std::string& manifest_url,
enable_crash_throttling(enable_crash_throttling) {
}
-NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& l) {
- manifest_url = l.manifest_url;
- render_view_id = l.render_view_id;
- permission_bits = l.permission_bits;
- uses_irt = l.uses_irt;
- enable_dyncode_syscalls = l.enable_dyncode_syscalls;
- enable_exception_handling = l.enable_exception_handling;
- enable_crash_throttling = l.enable_crash_throttling;
+NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& l)
+ : manifest_url(l.manifest_url),
+ nexe_file(l.nexe_file),
+ nexe_token_lo(l.nexe_token_lo),
+ nexe_token_hi(l.nexe_token_hi),
+ render_view_id(l.render_view_id),
+ permission_bits(l.permission_bits),
+ uses_irt(l.uses_irt),
+ uses_nonsfi_mode(l.uses_nonsfi_mode),
+ enable_dyncode_syscalls(l.enable_dyncode_syscalls),
+ enable_exception_handling(l.enable_exception_handling),
+ enable_crash_throttling(l.enable_crash_throttling) {
}
NaClLaunchParams::~NaClLaunchParams() {

Powered by Google App Engine
This is Rietveld 408576698