Remove LoadModule SRPC for non-SFI mode.

components/nacl/browser/nacl_host_message_filter.cc

Index: components/nacl/browser/nacl_host_message_filter.cc
diff --git a/components/nacl/browser/nacl_host_message_filter.cc b/components/nacl/browser/nacl_host_message_filter.cc
index a71f419358b74d586fa80c269b809f6973e2bd05..9a446ba18349ecef21d0800faa3d5baa885b1282 100644
--- a/components/nacl/browser/nacl_host_message_filter.cc
+++ b/components/nacl/browser/nacl_host_message_filter.cc
@@ -74,6 +74,9 @@ void NaClHostMessageFilter::OnLaunchNaCl(
     IPC::Message* reply_msg) {
   NaClProcessHost* host = new NaClProcessHost(
       GURL(launch_params.manifest_url),
+      IPC::PlatformFileForTransitToPlatformFile(launch_params.nexe_file),
+      launch_params.nexe_token_lo,

[Mark Seaborn, 2014/06/17 00:50:30]

I'm not sure you should be plumbing the file token values through here (yet),
for a number of reasons:

 * They are only meaningful when using validation caching, and this change only
affects Non-SFI mode.

 * I'm not sure if validation caching is hooked up yet for loading the initial
nexe.  (I'd have to ask jvoung about that.)

 * It would be suboptimal for the *browser* to pass the token values to the NaCl
process.  If the NaCl process uses validation caching, it would just turn around
and send the token values back to the browser -- see
NaClProcessMsg_ResolveFileToken -- in order to get a guaranteed-safe FD back. 
It would be more efficient for the browser to send a guaranteed-safe FD in the
first place!

If you are going to plumb them through, it seems like it would be better to use
"struct NaClFileToken" rather than passing two int values around.

[hidehiko, 2014/06/18 08:43:31]

Indeed. I just followed the Justin's CL. Admittedly, we don't need them for
non-SFI. Removed.

+      launch_params.nexe_token_hi,
       launch_params.render_view_id,
       launch_params.permission_bits,
       launch_params.uses_irt,