Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: components/nacl/common/nacl_types.cc

Issue 337463002: Remove LoadModule SRPC for non-SFI mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/common/nacl_types.h" 5 #include "components/nacl/common/nacl_types.h"
6 #include "ipc/ipc_platform_file.h" 6 #include "ipc/ipc_platform_file.h"
7 7
8 namespace nacl { 8 namespace nacl {
9 9
10 NaClStartParams::NaClStartParams() 10 NaClStartParams::NaClStartParams()
Mark Seaborn 2014/06/18 19:53:12 Init nexe_file here, since it's POD type.
hidehiko 2014/06/19 07:01:59 Done.
11 : validation_cache_enabled(false), 11 : validation_cache_enabled(false),
12 enable_exception_handling(false), 12 enable_exception_handling(false),
13 enable_debug_stub(false), 13 enable_debug_stub(false),
14 enable_ipc_proxy(false), 14 enable_ipc_proxy(false),
15 uses_irt(false), 15 uses_irt(false),
16 enable_dyncode_syscalls(false) { 16 enable_dyncode_syscalls(false) {
17 } 17 }
18 18
19 NaClStartParams::~NaClStartParams() { 19 NaClStartParams::~NaClStartParams() {
20 } 20 }
21 21
22 NaClLaunchParams::NaClLaunchParams() 22 NaClLaunchParams::NaClLaunchParams()
Mark Seaborn 2014/06/18 19:53:12 Ditto: Init nexe_file here, since it's POD type.
hidehiko 2014/06/19 07:01:59 Done.
23 : render_view_id(0), 23 : render_view_id(0),
24 permission_bits(0), 24 permission_bits(0),
25 uses_irt(false), 25 uses_irt(false),
26 enable_dyncode_syscalls(false), 26 enable_dyncode_syscalls(false),
27 enable_exception_handling(false), 27 enable_exception_handling(false),
28 enable_crash_throttling(false) { 28 enable_crash_throttling(false) {
29 } 29 }
30 30
31 NaClLaunchParams::NaClLaunchParams(const std::string& manifest_url, 31 NaClLaunchParams::NaClLaunchParams(
32 int render_view_id, 32 const std::string& manifest_url,
33 uint32 permission_bits, 33 const IPC::PlatformFileForTransit& nexe_file,
34 bool uses_irt, 34 int render_view_id,
35 bool uses_nonsfi_mode, 35 uint32 permission_bits,
36 bool enable_dyncode_syscalls, 36 bool uses_irt,
37 bool enable_exception_handling, 37 bool uses_nonsfi_mode,
38 bool enable_crash_throttling) 38 bool enable_dyncode_syscalls,
39 bool enable_exception_handling,
40 bool enable_crash_throttling)
39 : manifest_url(manifest_url), 41 : manifest_url(manifest_url),
42 nexe_file(nexe_file),
40 render_view_id(render_view_id), 43 render_view_id(render_view_id),
41 permission_bits(permission_bits), 44 permission_bits(permission_bits),
42 uses_irt(uses_irt), 45 uses_irt(uses_irt),
43 uses_nonsfi_mode(uses_nonsfi_mode), 46 uses_nonsfi_mode(uses_nonsfi_mode),
44 enable_dyncode_syscalls(enable_dyncode_syscalls), 47 enable_dyncode_syscalls(enable_dyncode_syscalls),
45 enable_exception_handling(enable_exception_handling), 48 enable_exception_handling(enable_exception_handling),
46 enable_crash_throttling(enable_crash_throttling) { 49 enable_crash_throttling(enable_crash_throttling) {
47 } 50 }
48 51
49 NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& l) { 52 NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& l)
50 manifest_url = l.manifest_url; 53 : manifest_url(l.manifest_url),
51 render_view_id = l.render_view_id; 54 nexe_file(l.nexe_file),
52 permission_bits = l.permission_bits; 55 render_view_id(l.render_view_id),
53 uses_irt = l.uses_irt; 56 permission_bits(l.permission_bits),
54 enable_dyncode_syscalls = l.enable_dyncode_syscalls; 57 uses_irt(l.uses_irt),
55 enable_exception_handling = l.enable_exception_handling; 58 uses_nonsfi_mode(l.uses_nonsfi_mode),
56 enable_crash_throttling = l.enable_crash_throttling; 59 enable_dyncode_syscalls(l.enable_dyncode_syscalls),
60 enable_exception_handling(l.enable_exception_handling),
61 enable_crash_throttling(l.enable_crash_throttling) {
57 } 62 }
58 63
59 NaClLaunchParams::~NaClLaunchParams() { 64 NaClLaunchParams::~NaClLaunchParams() {
60 } 65 }
61 66
62 NaClLaunchResult::NaClLaunchResult() 67 NaClLaunchResult::NaClLaunchResult()
63 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()), 68 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()),
64 ppapi_ipc_channel_handle(), 69 ppapi_ipc_channel_handle(),
65 trusted_ipc_channel_handle(), 70 trusted_ipc_channel_handle(),
66 plugin_pid(base::kNullProcessId), 71 plugin_pid(base::kNullProcessId),
(...skipping 12 matching lines...) Expand all
79 trusted_ipc_channel_handle(trusted_ipc_channel_handle), 84 trusted_ipc_channel_handle(trusted_ipc_channel_handle),
80 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle), 85 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle),
81 plugin_pid(plugin_pid), 86 plugin_pid(plugin_pid),
82 plugin_child_id(plugin_child_id) { 87 plugin_child_id(plugin_child_id) {
83 } 88 }
84 89
85 NaClLaunchResult::~NaClLaunchResult() { 90 NaClLaunchResult::~NaClLaunchResult() {
86 } 91 }
87 92
88 } // namespace nacl 93 } // namespace nacl
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698