Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 337453002: CHR-1796: Implement UIATextProvider::get_Value method. (Closed)

Created:
6 years, 6 months ago by mpichlinski
Modified:
6 years, 6 months ago
Reviewers:
dmazzoni, ananta, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CHR-1796: Implement UIATextProvider::get_Value method. On Windows 8 LDTP gettextvalue function uses IRawElementProviderSimple::GetPatternProvider for UIA_ValuePatternId and method IValueProvider::get_Value which is not implemented instead of IAccessible::get_accValue. BUG=384224 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/win/accessibility_misc_utils.h View 4 chunks +8 lines, -4 lines 0 comments Download
M ui/base/win/accessibility_misc_utils.cc View 3 chunks +9 lines, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
mpichlinski
Hi! Does this patch look OK to you? Br, Michał
6 years, 6 months ago (2014-06-12 08:42:57 UTC) #1
dmazzoni
lgtm Change looks great. Just for better tracking, could you file a bug and associate ...
6 years, 6 months ago (2014-06-12 16:04:18 UTC) #2
dmazzoni
+sky for ui/OWNERS
6 years, 6 months ago (2014-06-12 16:05:04 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-12 17:00:22 UTC) #4
mpichlinski
On 2014/06/12 16:04:18, dmazzoni wrote: > lgtm > > Change looks great. > > Just ...
6 years, 6 months ago (2014-06-13 06:22:14 UTC) #5
mpichlinski
The CQ bit was checked by mpichlinski@opera.com
6 years, 6 months ago (2014-06-13 06:22:23 UTC) #6
mpichlinski
The CQ bit was unchecked by mpichlinski@opera.com
6 years, 6 months ago (2014-06-13 06:22:25 UTC) #7
mpichlinski
The CQ bit was checked by mpichlinski@opera.com
6 years, 6 months ago (2014-06-16 11:29:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpichlinski@opera.com/337453002/1
6 years, 6 months ago (2014-06-16 11:30:14 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 13:45:15 UTC) #10
Message was sent while issue was closed.
Change committed as 277416

Powered by Google App Engine
This is Rietveld 408576698