Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 337443002: Fix min threshhold calculation for resizing the PDF graphics context (Closed)

Created:
6 years, 6 months ago by raymes
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Fix min threshhold calculation for resizing the PDF graphics context This fixes the calculation for the threshhold we use to calculate whether the graphics context needs to be resized. There isn't a correctness issue here, as the context will always be large enough but it results in resizing more than necessary. This example demonstrates the issue: -If the plugin size was 100 x 100, we would set the context size to 100+kBufferSize x 100+kBufferSize. -If the plugin was then resized to 90x90 we would check to see if the plugin size is smaller than (100+kBufferSize)-kBufferSize x (100+kBufferSize)-kBufferSize which is equal to 100 x 100. -But we really intend to check whether it is smaller than 100-kBufferSize x 100-kBufferSize Thus we should check whether the plugin is smaller than the (current context size) - 2*kBufferSize which is kBufferSize less than the plugin size when the context size was last computed. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pdf/paint_manager.cc View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
raymes
6 years, 6 months ago (2014-06-12 06:49:58 UTC) #1
raymes
-jabdelmalek +jam (sorry for the wrong address!)
6 years, 6 months ago (2014-06-13 00:30:31 UTC) #2
jam
lgtm
6 years, 6 months ago (2014-06-13 17:08:47 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-06-16 02:47:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/337443002/1
6 years, 6 months ago (2014-06-16 02:48:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 08:35:45 UTC) #6
Message was sent while issue was closed.
Change committed as 277387

Powered by Google App Engine
This is Rietveld 408576698