Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 337433003: Switch buildershandler over to using the json mirror. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Switch buildershandler over to using the json mirror. The json mirror is apparently better able to scale to load and is less dependent on the buildbot master being in good state. As part of this, we how have a way of querying the step information for the last build on a builder, so we can skip the request and code related to finding out the build number of the latest run. Change the masters data structure to store a url name instead of the whole URL. The url name is the master name to use for constructing URLs. This way buildershandler can use the mirror, but builders.js can continue pointing to the actual master for it's non-json queries. Also, get rid of the force_update code path in buildershandler. This seemed like a good idea at the time, but in practice it just masks errors by making it seem like things are working. The downside of deleting this is that persistent errors loading the JSON won't be noticed until the memcache is flushed for some reason. We should add monitoring of 500s to catch these things earlier. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -204 lines) Patch
M Tools/TestResultServer/handlers/buildershandler.py View 5 chunks +36 lines, -75 lines 0 comments Download
M Tools/TestResultServer/handlers/buildershandler_unittest.py View 3 chunks +73 lines, -114 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/aggregate_results_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/TestResultServer/static-dashboards/builders.js View 2 chunks +6 lines, -6 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/builders_unittest.jsonp View 5 chunks +3 lines, -3 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/builders_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/load_failures_unittests.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 6 months ago (2014-06-13 18:19:39 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-13 22:14:26 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-13 23:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/337433003/1
6 years, 6 months ago (2014-06-13 23:37:19 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 01:40:52 UTC) #5
Message was sent while issue was closed.
Change committed as 176147

Powered by Google App Engine
This is Rietveld 408576698