Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 337423002: Enable identity.email permission and chrome.identity.getProfileUserInfo API in stable (Closed)

Created:
6 years, 6 months ago by Michael Courage
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable identity.email permission and chrome.identity.getProfileUserInfo API in stable This change makes some small tweaks to identity.email and getProfileUserInfo based on apps-dev feedback, and enables them in stable. The UI string for identity.email now reads "Know your email address". chrome.identity.getProfileUserInfo can be called without the email permission (in which case it returns an ID only). BUG=368343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278867

Patch Set 1 #

Patch Set 2 : update permission string, getProfileUserInfo without email permission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 chunks +41 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael Courage
6 years, 6 months ago (2014-06-17 21:41:48 UTC) #1
miket_OOO
lgtm
6 years, 6 months ago (2014-06-20 16:11:04 UTC) #2
Michael Courage
PTAL
6 years, 6 months ago (2014-06-20 17:47:33 UTC) #3
miket_OOO
lgtm
6 years, 6 months ago (2014-06-20 17:55:14 UTC) #4
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 6 months ago (2014-06-20 18:22:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/337423002/20001
6 years, 6 months ago (2014-06-20 18:23:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 22:45:42 UTC) #7
not at google - send to devlin
(lgtm)
6 years, 6 months ago (2014-06-20 23:38:46 UTC) #8
commit-bot: I haz the power
Change committed as 278867
6 years, 6 months ago (2014-06-20 23:44:56 UTC) #9
karl_bsn.ie
6 years, 3 months ago (2014-08-28 11:28:24 UTC) #10
This permission should be documented, probably 
at https://developer.chrome.com/extensions/identity. 

On Saturday, June 21, 2014 12:44:58 AM UTC+1, commi...@chromium.org wrote:
>
> Change committed as 278867 
>
> https://codereview.chromium.org/337423002/ 
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698