Source/devtools/front_end/sdk/RemoteObject.js - Issue 337353002: Object properties with values of Symbol type should not be expandable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/RemoteObject.js

Issue 337353002: Object properties with values of Symbol type should not be expandable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/sdk/RemoteObject.js

diff --git a/Source/devtools/front_end/sdk/RemoteObject.js b/Source/devtools/front_end/sdk/RemoteObject.js

index b5b315ca0add2b50dccee60a00a30c8ae06859cc..ace5d5f43d0ab9a0d112dd101e03eacabe3f26e7 100644

--- a/Source/devtools/front_end/sdk/RemoteObject.js

+++ b/Source/devtools/front_end/sdk/RemoteObject.js

@@ -222,7 +222,7 @@ WebInspector.RemoteObjectImpl = function(target, objectId, type, subtype, value,

// handle

this._objectId = objectId;

this._description = description;

- this._hasChildren = true;

+ this._hasChildren = this._type === "symbol" ? false : true;

aandrey 2014/06/17 12:29:37 this._hasChildren = (type !== "symbol");

Alexandra Mikhaylova 2014/06/17 12:32:29 Done.

this._preview = preview;

} else {

// Primitive or null object.

« no previous file with comments | « no previous file | no next file » | no next file with comments »