Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 337353002: Object properties with values of Symbol type should not be expandable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 337353002: Object properties with values of Symbol type should not be expandable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/Source/devtools/front_end/components/ObjectPropertiesSection.js b/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 444f20361c223334de5cce988cd31602f923e93f..48290989727b572127970b6d8b42dc8cefcf6951 100644

--- a/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -243,7 +243,7 @@ WebInspector.ObjectPropertyTreeElement.prototype = {

this.listItemElement.removeChildren();

- this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown;

+ this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown && !(this.property.value.type === "symbol");

aandrey 2014/06/17 10:36:33 this.property.value.hasChildren should be false fo

} else {

if (this.property.getter) {

this.valueElement = WebInspector.ObjectPropertyTreeElement.createRemoteObjectAccessorPropertySpan(this.property.parentObject, [this.property.name], this._onInvokeGetterClick.bind(this));

« no previous file with comments | « no previous file | no next file » | no next file with comments »