Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 337353002: Object properties with values of Symbol type should not be expandable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 if (this.property.value.type === "object" && this.property.value.sub type === "node" && this.property.value.description) { 236 if (this.property.value.type === "object" && this.property.value.sub type === "node" && this.property.value.description) {
237 WebInspector.DOMPresentationUtils.createSpansForNodeTitle(this.v alueElement, this.property.value.description); 237 WebInspector.DOMPresentationUtils.createSpansForNodeTitle(this.v alueElement, this.property.value.description);
238 this.valueElement.addEventListener("mousemove", this._mouseMove. bind(this, this.property.value), false); 238 this.valueElement.addEventListener("mousemove", this._mouseMove. bind(this, this.property.value), false);
239 this.valueElement.addEventListener("mouseout", this._mouseOut.bi nd(this, this.property.value), false); 239 this.valueElement.addEventListener("mouseout", this._mouseOut.bi nd(this, this.property.value), false);
240 } else { 240 } else {
241 this.valueElement.title = description || ""; 241 this.valueElement.title = description || "";
242 } 242 }
243 243
244 this.listItemElement.removeChildren(); 244 this.listItemElement.removeChildren();
245 245
246 this.hasChildren = this.property.value.hasChildren && !this.property .wasThrown; 246 this.hasChildren = this.property.value.hasChildren && !this.property .wasThrown && !(this.property.value.type === "symbol");
aandrey 2014/06/17 10:36:33 this.property.value.hasChildren should be false fo
247 } else { 247 } else {
248 if (this.property.getter) { 248 if (this.property.getter) {
249 this.valueElement = WebInspector.ObjectPropertyTreeElement.creat eRemoteObjectAccessorPropertySpan(this.property.parentObject, [this.property.nam e], this._onInvokeGetterClick.bind(this)); 249 this.valueElement = WebInspector.ObjectPropertyTreeElement.creat eRemoteObjectAccessorPropertySpan(this.property.parentObject, [this.property.nam e], this._onInvokeGetterClick.bind(this));
250 } else { 250 } else {
251 this.valueElement = document.createElement("span"); 251 this.valueElement = document.createElement("span");
252 this.valueElement.className = "console-formatted-undefined"; 252 this.valueElement.className = "console-formatted-undefined";
253 this.valueElement.textContent = WebInspector.UIString("<unreadab le>"); 253 this.valueElement.textContent = WebInspector.UIString("<unreadab le>");
254 this.valueElement.title = WebInspector.UIString("No property get ter"); 254 this.valueElement.title = WebInspector.UIString("No property get ter");
255 } 255 }
256 } 256 }
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
999 { 999 {
1000 WebInspector.TextPrompt.call(this, WebInspector.ExecutionContextSelector.com pletionsForTextPromptInCurrentContext); 1000 WebInspector.TextPrompt.call(this, WebInspector.ExecutionContextSelector.com pletionsForTextPromptInCurrentContext);
1001 this.setSuggestBoxEnabled(true); 1001 this.setSuggestBoxEnabled(true);
1002 if (renderAsBlock) 1002 if (renderAsBlock)
1003 this.renderAsBlock(); 1003 this.renderAsBlock();
1004 } 1004 }
1005 1005
1006 WebInspector.ObjectPropertyPrompt.prototype = { 1006 WebInspector.ObjectPropertyPrompt.prototype = {
1007 __proto__: WebInspector.TextPrompt.prototype 1007 __proto__: WebInspector.TextPrompt.prototype
1008 } 1008 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698