Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: Source/modules/mediastream/RTCPeerConnection.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/RTCDTMFSender.idl ('k') | Source/modules/mediastream/RTCStatsResponse.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/RTCPeerConnection.idl
diff --git a/Source/modules/mediastream/RTCPeerConnection.idl b/Source/modules/mediastream/RTCPeerConnection.idl
index fa5494606e720f8f19b2043bc0492e96f623dd77..b9199e324f48593ac1d640bcd4ac0780cea48f08 100644
--- a/Source/modules/mediastream/RTCPeerConnection.idl
+++ b/Source/modules/mediastream/RTCPeerConnection.idl
@@ -36,14 +36,14 @@
NoInterfaceObject,
RaisesException=Constructor,
] interface RTCPeerConnection : EventTarget {
- [RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);
+ [RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, optional RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);
- [RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
+ [RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
- [RaisesException] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException] void setLocalDescription(RTCSessionDescription description, optional VoidCallback successCallback, optional RTCErrorCallback failureCallback);
[RaisesException=Getter] readonly attribute RTCSessionDescription localDescription;
- [RaisesException] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException] void setRemoteDescription(RTCSessionDescription description, optional VoidCallback successCallback, optional RTCErrorCallback failureCallback);
[RaisesException=Getter] readonly attribute RTCSessionDescription remoteDescription;
readonly attribute DOMString signalingState;
@@ -65,7 +65,7 @@
[TypeChecking=Interface, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
[TypeChecking=Interface, RaisesException] void removeStream(MediaStream? stream);
- void getStats(RTCStatsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selector);
+ void getStats(RTCStatsCallback successCallback, optional MediaStreamTrack selector);
[RaisesException] RTCDataChannel createDataChannel([TreatUndefinedAs=NullString] DOMString? label, optional Dictionary options);
« no previous file with comments | « Source/modules/mediastream/RTCDTMFSender.idl ('k') | Source/modules/mediastream/RTCStatsResponse.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698