Source/modules/indexeddb/InspectorIndexedDBAgent.cpp - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

diff --git a/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp b/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

index 662138c74e11145f9fb54343861fc224d4a191ae..0dc1cde33fc9be5f60775717dc2f35d3fc9d0cea 100644

--- a/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

+++ b/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

@@ -193,7 +193,7 @@ void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin*, cons

{

RefPtr<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);

TrackExceptionState exceptionState;

- IDBOpenDBRequest* idbOpenDBRequest = idbFactory->open(scriptState(), databaseName, exceptionState);

+ IDBOpenDBRequest* idbOpenDBRequest = idbFactory->open(scriptState(), databaseName, makeOptional(IDBDatabaseMetadata::NoIntVersion), exceptionState);

if (exceptionState.hadException()) {

requestCallback()->sendFailure("Could not open database.");

return;

« no previous file with comments | « Source/modules/indexeddb/IDBObjectStore.idl ('k') | Source/modules/mediastream/RTCDTMFSender.h » ('j') | no next file with comments »