Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: Source/modules/indexeddb/IDBFactory.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBCursor.idl ('k') | Source/modules/indexeddb/IDBFactory.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBFactory.h
diff --git a/Source/modules/indexeddb/IDBFactory.h b/Source/modules/indexeddb/IDBFactory.h
index a3588cdbd2ebcc06a29e01b3c4066491bdaaaf0c..dab830955b823fa1731b8b768cacfca6160bda6c 100644
--- a/Source/modules/indexeddb/IDBFactory.h
+++ b/Source/modules/indexeddb/IDBFactory.h
@@ -28,6 +28,7 @@
#ifndef IDBFactory_h
#define IDBFactory_h
+#include "bindings/core/v8/Optional.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/indexeddb/IDBOpenDBRequest.h"
#include "modules/indexeddb/IndexedDBClient.h"
@@ -51,8 +52,7 @@ public:
IDBRequest* getDatabaseNames(ScriptState*, ExceptionState&);
- IDBOpenDBRequest* open(ScriptState*, const String& name, ExceptionState&);
- IDBOpenDBRequest* open(ScriptState*, const String& name, unsigned long long version, ExceptionState&);
+ IDBOpenDBRequest* open(ScriptState*, const String& name, Optional<unsigned long long> version, ExceptionState&);
IDBOpenDBRequest* deleteDatabase(ScriptState*, const String& name, ExceptionState&);
short cmp(ScriptState*, const ScriptValue& first, const ScriptValue& second, ExceptionState&);
@@ -60,8 +60,6 @@ public:
private:
explicit IDBFactory(IndexedDBClient*);
- IDBOpenDBRequest* openInternal(ScriptState*, const String& name, int64_t version, ExceptionState&);
-
Member<IndexedDBClient> m_permissionClient;
};
« no previous file with comments | « Source/modules/indexeddb/IDBCursor.idl ('k') | Source/modules/indexeddb/IDBFactory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698