Source/core/html/HTMLSelectElement.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.idl

diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl

index 8b6d6a467ae0cc55173c99231f03e7f2f364d8a6..b3c471ca0579e2ce5bde86982191820d17476b90 100644

--- a/Source/core/html/HTMLSelectElement.idl

+++ b/Source/core/html/HTMLSelectElement.idl

@@ -36,7 +36,7 @@ interface HTMLSelectElement : HTMLElement {

[RaisesException=Setter] attribute unsigned long length;

getter Element item(unsigned long index);

- Element namedItem([Default=Undefined] optional DOMString name);

+ Element namedItem(optional DOMString name);

// FIXME: should be union type http://crbug.com/240176

[RaisesException, TypeChecking=Interface] void add(HTMLElement element, optional HTMLElement? before = null);

[ImplementedAs=addBeforeOptionAtIndex, RaisesException, TypeChecking=Interface] void add(HTMLElement element, long before);

« no previous file with comments | « Source/core/html/HTMLOptionsCollection.idl ('k') | Source/core/html/HTMLTableElement.h » ('j') | no next file with comments »