Source/core/fileapi/File.h - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/File.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fileapi/File.h

diff --git a/Source/core/fileapi/File.h b/Source/core/fileapi/File.h

index 9b195a32c8094727e897e7377b7728cf6658831b..a7ac9ba0259fa44bb40f09f37382cade1a75eb62 100644

--- a/Source/core/fileapi/File.h

+++ b/Source/core/fileapi/File.h

@@ -104,7 +104,7 @@ public:

}

virtual unsigned long long size() const OVERRIDE;

- virtual PassRefPtrWillBeRawPtr<Blob> slice(long long start, long long end, const String& contentType, ExceptionState&) const OVERRIDE;

+ virtual PassRefPtrWillBeRawPtr<Blob> slice(long long start, Optional<long long> end, const String& contentType, ExceptionState&) const OVERRIDE;

virtual void close(ExecutionContext*, ExceptionState&) OVERRIDE;

virtual bool isFile() const OVERRIDE { return true; }

« no previous file with comments | « Source/core/fileapi/Blob.cpp ('k') | Source/core/fileapi/File.cpp » ('j') | no next file with comments »