Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: Source/core/fileapi/Blob.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/UIEvent.idl ('k') | Source/core/fileapi/Blob.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fileapi/Blob.h
diff --git a/Source/core/fileapi/Blob.h b/Source/core/fileapi/Blob.h
index d1263177b5548e67aad7673675f9fadc0002af82..effe9464f5c947f725c67351bdc3c9a396f2724d 100644
--- a/Source/core/fileapi/Blob.h
+++ b/Source/core/fileapi/Blob.h
@@ -31,6 +31,7 @@
#ifndef Blob_h
#define Blob_h
+#include "bindings/core/v8/Optional.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/html/URLRegistry.h"
#include "platform/blob/BlobData.h"
@@ -60,21 +61,7 @@ public:
virtual ~Blob();
virtual unsigned long long size() const { return m_blobDataHandle->size(); }
- virtual PassRefPtrWillBeRawPtr<Blob> slice(long long start, long long end, const String& contentType, ExceptionState&) const;
-
- // To allow ExceptionState to be passed in last, manually enumerate the optional argument overloads.
- PassRefPtrWillBeRawPtr<Blob> slice(ExceptionState& exceptionState) const
- {
- return slice(0, std::numeric_limits<long long>::max(), String(), exceptionState);
- }
- PassRefPtrWillBeRawPtr<Blob> slice(long long start, ExceptionState& exceptionState) const
- {
- return slice(start, std::numeric_limits<long long>::max(), String(), exceptionState);
- }
- PassRefPtrWillBeRawPtr<Blob> slice(long long start, long long end, ExceptionState& exceptionState) const
- {
- return slice(start, end, String(), exceptionState);
- }
+ virtual PassRefPtrWillBeRawPtr<Blob> slice(long long start, Optional<long long> optionalEnd, const String& contentType, ExceptionState&) const;
virtual void close(ExecutionContext*, ExceptionState&);
« no previous file with comments | « Source/core/events/UIEvent.idl ('k') | Source/core/fileapi/Blob.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698