Source/core/dom/ElementFullscreen.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementFullscreen.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ElementFullscreen.idl

diff --git a/Source/core/dom/ElementFullscreen.idl b/Source/core/dom/ElementFullscreen.idl

index 6f45402fe28d7bc2b0ec57f02ede0407b387580c..3ddcce3ae4014c0634078eff56668b1b6a672277 100644

--- a/Source/core/dom/ElementFullscreen.idl

+++ b/Source/core/dom/ElementFullscreen.idl

@@ -7,7 +7,7 @@ partial interface Element {

// Mozilla version

const unsigned short ALLOW_KEYBOARD_INPUT = 1;

- [LogActivity, LogAllWorlds, MeasureAs=PrefixedElementRequestFullScreen] void webkitRequestFullScreen([Default=Undefined] optional unsigned short flags);

+ [LogActivity, LogAllWorlds, MeasureAs=PrefixedElementRequestFullScreen] void webkitRequestFullScreen(optional unsigned short flags);

// W3C version

[LogActivity, LogAllWorlds, MeasureAs=PrefixedElementRequestFullscreen] void webkitRequestFullscreen();

« no previous file with comments | « Source/core/dom/Element.idl ('k') | Source/core/dom/NamedNodeMap.idl » ('j') | no next file with comments »