Source/core/dom/DOMTokenList.h - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMTokenList.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMTokenList.h

diff --git a/Source/core/dom/DOMTokenList.h b/Source/core/dom/DOMTokenList.h

index 5bb39cd7cdd1efce083dcf11f02137e46e7fef76..8a8f2dd6b8fae3e1e7c2462b2e9b972e4d41af65 100644

--- a/Source/core/dom/DOMTokenList.h

+++ b/Source/core/dom/DOMTokenList.h

@@ -25,6 +25,7 @@

#ifndef DOMTokenList_h

#define DOMTokenList_h

+#include "bindings/core/v8/Optional.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "platform/heap/Handle.h"

#include "wtf/Vector.h"

@@ -58,8 +59,7 @@ public:

void add(const AtomicString&, ExceptionState&);

virtual void remove(const Vector<String>&, ExceptionState&);

void remove(const AtomicString&, ExceptionState&);

- bool toggle(const AtomicString&, ExceptionState&);

- bool toggle(const AtomicString&, bool force, ExceptionState&);

+ bool toggle(const AtomicString&, Optional<bool> force, ExceptionState&);

const AtomicString& toString() const { return value(); }

« no previous file with comments | « Source/core/dom/DOMStringList.idl ('k') | Source/core/dom/DOMTokenList.cpp » ('j') | no next file with comments »