Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: Source/core/css/FontFaceSet.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSSupportsRule.idl ('k') | Source/core/css/FontFaceSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/FontFaceSet.h
diff --git a/Source/core/css/FontFaceSet.h b/Source/core/css/FontFaceSet.h
index 19a01bcc8eaf316131e723188d98bbc7d06c0fa9..5d575eb2aa8dc2cb349d6d84e6a421c4349eeec2 100644
--- a/Source/core/css/FontFaceSet.h
+++ b/Source/core/css/FontFaceSet.h
@@ -26,6 +26,7 @@
#ifndef FontFaceSet_h
#define FontFaceSet_h
+#include "bindings/core/v8/Optional.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "core/css/FontFace.h"
#include "core/css/FontFaceSetForEachCallback.h"
@@ -80,8 +81,7 @@ public:
void add(FontFace*, ExceptionState&);
void clear();
bool remove(FontFace*, ExceptionState&);
- void forEach(PassOwnPtr<FontFaceSetForEachCallback>, ScriptValue& thisArg) const;
- void forEach(PassOwnPtr<FontFaceSetForEachCallback>) const;
+ void forEach(PassOwnPtr<FontFaceSetForEachCallback>, const Optional<ScriptValue>& thisArg) const;
bool has(FontFace*, ExceptionState&) const;
unsigned long size() const;
@@ -136,7 +136,6 @@ private:
bool hasLoadedFonts() const { return !m_loadedFonts.isEmpty() || !m_failedFonts.isEmpty(); }
bool inActiveDocumentContext() const;
- void forEachInternal(PassOwnPtr<FontFaceSetForEachCallback>, ScriptValue* thisArg) const;
void addToLoadingFonts(PassRefPtrWillBeRawPtr<FontFace>);
void removeFromLoadingFonts(PassRefPtrWillBeRawPtr<FontFace>);
void fireLoadingEvent();
« no previous file with comments | « Source/core/css/CSSSupportsRule.idl ('k') | Source/core/css/FontFaceSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698