Source/core/css/CSSStyleSheet.h - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSStyleSheet.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSStyleSheet.h

diff --git a/Source/core/css/CSSStyleSheet.h b/Source/core/css/CSSStyleSheet.h

index 176061f5a7de7036a84c85d8d61b3473751ba071..2b91f05806a427842d2b35ae4177f3bdd1af37f5 100644

--- a/Source/core/css/CSSStyleSheet.h

+++ b/Source/core/css/CSSStyleSheet.h

@@ -21,6 +21,7 @@

#ifndef CSSStyleSheet_h

#define CSSStyleSheet_h

+#include "bindings/core/v8/Optional.h"

#include "core/css/CSSRule.h"

#include "core/css/StyleSheet.h"

#include "platform/heap/Handle.h"

@@ -71,8 +72,7 @@ public:

// IE Extensions

PassRefPtrWillBeRawPtr<CSSRuleList> rules();

- int addRule(const String& selector, const String& style, int index, ExceptionState&);

- int addRule(const String& selector, const String& style, ExceptionState&);

+ int addRule(const String& selector, const String& style, Optional<int> index, ExceptionState&);

void removeRule(unsigned index, ExceptionState& exceptionState) { deleteRule(index, exceptionState); }

// For CSSRuleList.

« no previous file with comments | « Source/core/css/CSSStyleDeclaration.idl ('k') | Source/core/css/CSSStyleSheet.cpp » ('j') | no next file with comments »