Source/bindings/scripts/v8_interface.py - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 1b061eb908170608b139bd5e5fa7a1c151cc3e6c..58cbf45047f45fbaffac42c6bd7ee131755e56f4 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -869,8 +869,7 @@ def constructor_context(interface, constructor):

'cpp_type': cpp_template_type(

cpp_ptr_type('RefPtr', 'RawPtr', gc_type(interface)),

cpp_name(interface)),

- 'cpp_value': v8_methods.cpp_value(

- interface, constructor, len(constructor.arguments)),

+ 'cpp_value': v8_methods.cpp_value(interface, constructor),

'has_exception_state':

is_constructor_raises_exception or

any(argument for argument in constructor.arguments

« no previous file with comments | « Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »