Source/bindings/core/v8/V8Binding.h - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8Binding.h

diff --git a/Source/bindings/core/v8/V8Binding.h b/Source/bindings/core/v8/V8Binding.h

index 4c57f6efec798422a1517e29cc192a35c6e50f9a..ade13cf322b0f869dbd73cec0e388fbe58ed1e55 100644

--- a/Source/bindings/core/v8/V8Binding.h

+++ b/Source/bindings/core/v8/V8Binding.h

@@ -62,8 +62,6 @@ namespace TraceEvent {

class ConvertableToTraceFormat;

}

-const int kMaxRecursionDepth = 22;

// Helpers for throwing JavaScript TypeErrors for arity mismatches.

void setArityTypeError(ExceptionState&, const char* valid, unsigned provided);

v8::Local<v8::Value> createMinimumArityTypeErrorForMethod(const char* method, const char* type, unsigned expected, unsigned provided, v8::Isolate*);

« no previous file with comments | « Source/bindings/core/v8/Optional.h ('k') | Source/bindings/core/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »