IDL: make optional arguments (without default) explicit sometimes

Source/modules/websockets/DOMWebSocket.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 230 matching lines @@
 DOMWebSocket::~DOMWebSocket()
 {
     ASSERT(!m_channel);
 }
 
 void DOMWebSocket::logError(const String& message)
 {
     executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
-DOMWebSocket* DOMWebSocket::create(ExecutionContext* context, const String& url, ExceptionState& exceptionState)
-{
-    Vector<String> protocols;
-    return create(context, url, protocols, exceptionState);
-}
-
 DOMWebSocket* DOMWebSocket::create(ExecutionContext* context, const String& url, const Vector<String>& protocols, ExceptionState& exceptionState)
 {
     if (url.isNull()) {
         exceptionState.throwDOMException(SyntaxError, "Failed to create a WebSocket: the provided URL is invalid.");
         return nullptr;
     }
 
     DOMWebSocket* webSocket(adoptRefCountedGarbageCollectedWillBeNoop(new DOMWebSocket(context)));
     webSocket->suspendIfNeeded();
 
     webSocket->connect(url, protocols, exceptionState);
     if (exceptionState.hadException())
         return nullptr;
 
     return webSocket;
 }
 
 DOMWebSocket* DOMWebSocket::create(ExecutionContext* context, const String& url, const String& protocol, ExceptionState& exceptionState)
 {
     Vector<String> protocols;
-    protocols.append(protocol);
+    if (!protocol.isNull())
+        protocols.append(protocol);
     return create(context, url, protocols, exceptionState);
 }
 
 void DOMWebSocket::connect(const String& url, const Vector<String>& protocols, ExceptionState& exceptionState)
 {
     WTF_LOG(Network, "WebSocket %p connect() url='%s'", this, url.utf8().data());
     m_url = KURL(KURL(), url);
 
     if (!m_url.isValid()) {
         m_state = CLOSED;
@@ skipping 152 matching lines @@
     if (m_state == CLOSING || m_state == CLOSED) {
         updateBufferedAmountAfterClose(static_cast<unsigned long>(binaryData->size()));
         return;
     }
     Platform::current()->histogramEnumeration("WebCore.WebSocket.SendType", WebSocketSendTypeBlob, WebSocketSendTypeMax);
     m_bufferedAmount += binaryData->size();
     ASSERT(m_channel);
     m_channel->send(binaryData->blobDataHandle());
 }
 
-void DOMWebSocket::close(unsigned short code, const String& reason, ExceptionState& exceptionState)
+void DOMWebSocket::close(Optional<unsigned short> optionalCode, const String& reason, ExceptionState& exceptionState)
 {
-    closeInternal(code, reason, exceptionState);
-}
-
-void DOMWebSocket::close(ExceptionState& exceptionState)
-{
-    closeInternal(WebSocketChannel::CloseEventCodeNotSpecified, String(), exceptionState);
-}
-
-void DOMWebSocket::close(unsigned short code, ExceptionState& exceptionState)
-{
-    closeInternal(code, String(), exceptionState);
+    closeInternal(optionalCode.isMissing() ? WebSocketChannel::CloseEventCodeNotSpecified : optionalCode.get(), reason, exceptionState);
 }
 
 void DOMWebSocket::closeInternal(int code, const String& reason, ExceptionState& exceptionState)
 {
     if (code == WebSocketChannel::CloseEventCodeNotSpecified) {
         WTF_LOG(Network, "WebSocket %p close() without code and reason", this);
     } else {
         WTF_LOG(Network, "WebSocket %p close() code=%d reason='%s'", this, code, reason.utf8().data());
         if (!(code == WebSocketChannel::CloseEventCodeNormalClosure || (WebSocketChannel::CloseEventCodeMinimumUserDefined <= code && code <= WebSocketChannel::CloseEventCodeMaximumUserDefined))) {
             exceptionState.throwDOMException(InvalidAccessError, "The code must be either 1000, or between 3000 and 4999. " + String::number(code) + " is neither.");
@@ skipping 215 matching lines @@
 
 void DOMWebSocket::trace(Visitor* visitor)
 {
     visitor->trace(m_channel);
     visitor->trace(m_eventQueue);
     WebSocketChannelClient::trace(visitor);
     EventTargetWithInlineData::trace(visitor);
 }
 
 } // namespace blink