Source/core/html/HTMLAllCollection.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLAllCollection.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/frame/WindowTimers.idl ('k') | Source/core/html/HTMLCanvasElement.idl » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Apple Inc. All rights reserved.	2 * Copyright (C) 2009 Apple Inc. All rights reserved.

3 * Copyright (C) 2014 Samsung Electronics. All rights reserved.	3 * Copyright (C) 2014 Samsung Electronics. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 // FIXME: This interface should inherit HTMLCollection.	27 // FIXME: This interface should inherit HTMLCollection.

28 [	28 [

29 Custom=LegacyCallAsFunction,	29 Custom=LegacyCallAsFunction,

30 DependentLifetime,	30 DependentLifetime,

31 SetWrapperReferenceFrom=ownerNode,	31 SetWrapperReferenceFrom=ownerNode,

32 WillBeGarbageCollected,	32 WillBeGarbageCollected,

33 ] interface HTMLAllCollection {	33 ] interface HTMLAllCollection {

34 readonly attribute unsigned long length;	34 readonly attribute unsigned long length;

35 [ImplementedAs=item] getter Element (unsigned long index);	35 [ImplementedAs=item] getter Element (unsigned long index);

36 [Custom] Element item([Default=Undefined] optional unsigned long index);	36 [Custom] Element item(optional unsigned long index);

37 // FIXME: This should return an (HTMLCollection or Element) union.	37 // FIXME: This should return an (HTMLCollection or Element) union.

38 [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);	38 [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);

39 };	39 };

OLD	NEW