Fix for RenderListBox not showing vertical scrollbar with overlay-scrollbar enabled.

Fix for RenderListBox not showing vertical scrollbar with overlay-scrollbar enabled.

The scrollbars does not paint as verticalScrollbarWidth() returns 0 in paint in case of overlay-scrollbars.
We should use actual scrollbar width while placing and painting the scrollbar.

BUG=385463
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176395

[pals, 2014-06-17 14:08:37]

PTAL.

[tkent, 2014-06-18 00:03:00]

Please post a compilable patch.

[pals, 2014-06-18 04:23:04]

On 2014/06/18 00:03:00, tkent wrote:
> Please post a compilable patch.

Fixed the compilation error. Please take another look.

[tkent, 2014-06-18 04:52:22]

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
File Source/core/rendering/RenderListBox.cpp (right):

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
Source/core/rendering/RenderListBox.cpp:390: scrollbarLeft = width() -
borderRight() - (m_vBar ? m_vBar->width() : 0);
Why isn't this verticalScrollbarWidth()?

[pals, 2014-06-18 05:11:44]

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
File Source/core/rendering/RenderListBox.cpp (right):

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
Source/core/rendering/RenderListBox.cpp:390: scrollbarLeft = width() -
borderRight() - (m_vBar ? m_vBar->width() : 0);
On 2014/06/18 04:52:22, tkent wrote:
> Why isn't this verticalScrollbarWidth()?
As we see, in case of overlayscrollbars, verticalScrollbarWidth() return 0, so,
in case of "dir: ltr" the scrollbar will be placed at width() [assuming
borderRight() is 0] which at the edge/outside of the Box. So, we will not be
able to see the scrollbar.

[tkent, 2014-06-18 05:14:42]

lgtm

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
File Source/core/rendering/RenderListBox.cpp (right):

https://codereview.chromium.org/337323002/diff/110001/Source/core/rendering/R...
Source/core/rendering/RenderListBox.cpp:390: scrollbarLeft = width() -
borderRight() - (m_vBar ? m_vBar->width() : 0);
On 2014/06/18 05:11:44, sanjoy.pal wrote:
> On 2014/06/18 04:52:22, tkent wrote:
> > Why isn't this verticalScrollbarWidth()?
> As we see, in case of overlayscrollbars, verticalScrollbarWidth() return 0,
so,
> in case of "dir: ltr" the scrollbar will be placed at width() [assuming
> borderRight() is 0] which at the edge/outside of the Box. So, we will not be
> able to see the scrollbar. 
> 

Ah, I see. This function calculates the position of scrollbar.
Thanks.

[commit-bot: I haz the power, 2014-06-18 05:16:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/337323002/110001

[commit-bot: I haz the power, 2014-06-18 06:22:41]

Change committed as 176395