Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337283004: Inline usages of TimelineUIUtils.categoryForRecord (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Inline usages of TimelineUIUtils.categoryForRecord BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M LayoutTests/inspector/timeline/timeline-script-tag-1.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 6 months ago (2014-06-17 15:26:24 UTC) #1
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-17 15:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/337283004/1
6 years, 6 months ago (2014-06-17 15:50:36 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 15:50:37 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 15:50:38 UTC) #5
caseq
lgtm
6 years, 6 months ago (2014-06-18 07:30:00 UTC) #6
yurys
6 years, 6 months ago (2014-06-18 07:41:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as r176400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698