Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 337283003: Add UseCounter for synchronous XMLHttpRequests (Closed)

Created:
6 years, 6 months ago by maheshkk
Modified:
6 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add UseCounter for synchronous XMLHttpRequests This patch adds a UseCounter for only synchronous XMLHttpRequests. This will count exactly once per per page using sync XHR requests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176351

Patch Set 1 #

Patch Set 2 : Count only for XHR with document #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
maheshkk
As per our discussion earlier from https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4 PTAL
6 years, 6 months ago (2014-06-17 18:40:44 UTC) #1
eseidel
6 years, 6 months ago (2014-06-17 19:16:39 UTC) #2
eseidel
lgtm
6 years, 6 months ago (2014-06-17 19:16:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/337283003/20001
6 years, 6 months ago (2014-06-17 19:17:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 20:23:18 UTC) #5
Message was sent while issue was closed.
Change committed as 176351

Powered by Google App Engine
This is Rietveld 408576698