Issue 337243004: Add SkASSERTF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337243004: Add SkASSERTF. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
bsalomon, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add SkASSERTF. Example failure: fRefCnt was 3 ../../../usr/local/google/home/mtklein/skia/include/core/SkRefCnt.h:40: failed assertion "(fRefCnt == 1) || (SkDebugf("fRefCnt was %d""\n", fRefCnt), false)" Command terminated by signal 11 Not pretty, but everything's there. Perhaps we'll think of ways to make it nicer later. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b59161f0000eb4aca3dcef29f27ffd0fb5a568e5

Patch Set 1 #

Patch Set 2 : comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	include/core/SkRefCnt.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	include/core/SkTypes.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/337243004/20001

6 years, 6 months ago (2014-06-18 14:26:46 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-18 14:54:51 UTC) #6

Message was sent while issue was closed.

Change committed as b59161f0000eb4aca3dcef29f27ffd0fb5a568e5

Expand Messages | Collapse Messages