Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 337243002: Update default mcpu values to not use SSSE3 and tune for pre-sandybridge CPUs (Closed)

Created:
6 years, 6 months ago by Derek Schuff
Modified:
6 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update default mcpu values to not use SSSE3 and tune for pre-sandybridge CPUs The "x86-64" value is the base 64-bit target which does not use SSE3+ as core2 did. The pentium4m mcpu value is the same as pentium4 but uses x86.td's FeatureSlowBTMem attribute meaning "Bit testing of memory is slow" which is true for pre-sandybridge CPUs (which are probably still prevalent, and in any case matches the 64-bit code) BUG=https://code.google.com/p/nativeclient/issues/detail?id=2205 R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pnacl/driver/pnacl-translate.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jvoung (off chromium)
lgtm
6 years, 6 months ago (2014-06-16 22:05:03 UTC) #1
Derek Schuff
6 years, 6 months ago (2014-06-17 15:59:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r13362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698