Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 337223004: terminatePaused (Closed)

Created:
6 years, 6 months ago by michaeln
Modified:
6 years, 6 months ago
Reviewers:
falken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix a bug in the pause after download change that was recently committed, trying to terminate a paused worker would hang. TBR=jochen BUG=371671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176948

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
ptal, there's a browsertest for this which is disabled right now due to this bug. ...
6 years, 6 months ago (2014-06-25 00:30:10 UTC) #1
falken
lgtm
6 years, 6 months ago (2014-06-25 00:49:23 UTC) #2
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 6 months ago (2014-06-25 19:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/337223004/20001
6 years, 6 months ago (2014-06-25 19:45:37 UTC) #4
michaeln
The CQ bit was unchecked by michaeln@chromium.org
6 years, 6 months ago (2014-06-25 19:50:45 UTC) #5
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 6 months ago (2014-06-25 19:51:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/337223004/20001
6 years, 6 months ago (2014-06-25 19:52:29 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 20:50:13 UTC) #8
Message was sent while issue was closed.
Change committed as 176948

Powered by Google App Engine
This is Rietveld 408576698