chrome/browser/apps/app_browsertest.cc - Issue 337213004: Re-enable PlatformAppBrowserTest.Messaging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 337213004: Re-enable PlatformAppBrowserTest.Messaging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/app_browsertest.cc

diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc

index 7e6ffe477d6510d5b9a2e890edfe1434ada4157b..3c6c946f607c875888f804e33f8068a4e4df7369 100644

--- a/chrome/browser/apps/app_browsertest.cc

+++ b/chrome/browser/apps/app_browsertest.cc

@@ -1041,13 +1041,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ComponentAppBackgroundPage) {

ASSERT_TRUE(launched_listener.WaitUntilSatisfied());

}

-// Flakes on Windows: http://crbug.com/171450

-#if defined(OS_WIN)

-#define MAYBE_Messaging DISABLED_Messaging

-#else

-#define MAYBE_Messaging Messaging

-#endif

-IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_Messaging) {

+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, Messaging) {

ExtensionApiTest::ResultCatcher result_catcher;

LoadAndLaunchPlatformApp("messaging/app2", "Launched");

LoadAndLaunchPlatformApp("messaging/app1", "Launched");

« no previous file with comments | « no previous file | no next file » | no next file with comments »