Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Unified Diff: ash/wm/workspace/workspace_layout_manager_unittest.cc

Issue 337193002: WorkspaceLayoutManager backdrop should fill entire region. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Precondition to Test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_layout_manager_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_layout_manager_unittest.cc
diff --git a/ash/wm/workspace/workspace_layout_manager_unittest.cc b/ash/wm/workspace/workspace_layout_manager_unittest.cc
index 651f1f8cd1a49ebe8a9693638e09fb7b3fb87ccb..d3a4b5273f28142ee0838e80d0cf90671372a8df 100644
--- a/ash/wm/workspace/workspace_layout_manager_unittest.cc
+++ b/ash/wm/workspace/workspace_layout_manager_unittest.cc
@@ -4,6 +4,8 @@
#include "ash/wm/workspace/workspace_layout_manager.h"
+#include <string>
+
#include "ash/display/display_layout.h"
#include "ash/display/display_manager.h"
#include "ash/root_window_controller.h"
@@ -39,7 +41,7 @@ namespace {
class MaximizeDelegateView : public views::WidgetDelegateView {
public:
- MaximizeDelegateView(const gfx::Rect& initial_bounds)
+ explicit MaximizeDelegateView(const gfx::Rect& initial_bounds)
: initial_bounds_(initial_bounds) {
}
virtual ~MaximizeDelegateView() {}
@@ -788,9 +790,6 @@ class WorkspaceLayoutManagerBackdropTest : public test::AshTestBase {
UpdateDisplay("800x600");
default_container_ = Shell::GetContainer(Shell::GetPrimaryRootWindow(),
kShellWindowId_DefaultContainer);
- // We set the size to something smaller then the display to avoid resizing
- // issues with the shelf.
- default_container_->SetBounds(gfx::Rect(0, 0, 800, 500));
}
aura::Window* CreateTestWindow(const gfx::Rect& bounds) {
@@ -942,6 +941,33 @@ TEST_F(WorkspaceLayoutManagerBackdropTest, VerifyBackdropAndItsStacking) {
window3.get()));
}
+// Tests that when hidding the shelf, that the backdrop resizes to fill the
+// entire workspace area.
+TEST_F(WorkspaceLayoutManagerBackdropTest, ShelfVisibilityChangesBounds) {
+ ShelfLayoutManager* shelf_layout_manager =
+ Shell::GetPrimaryRootWindowController()->GetShelfLayoutManager();
+ ShowTopWindowBackdrop(true);
+ RunAllPendingInMessageLoop();
+
+ ASSERT_EQ(SHELF_VISIBLE, shelf_layout_manager->visibility_state());
+ gfx::Rect initial_bounds = default_container()->children()[0]->bounds();
+ shelf_layout_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
+ shelf_layout_manager->UpdateVisibilityState();
+
+ // When the shelf is re-shown WorkspaceLayoutManager shrinks all children
+ // including the backdrop.
+ shelf_layout_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
+ shelf_layout_manager->UpdateVisibilityState();
+ gfx::Rect reduced_bounds = default_container()->children()[0]->bounds();
+ EXPECT_LT(reduced_bounds.height(), initial_bounds.height());
+
+ shelf_layout_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
+ shelf_layout_manager->UpdateVisibilityState();
+
+ EXPECT_GT(default_container()->children()[0]->bounds().height(),
+ reduced_bounds.height());
+}
+
class WorkspaceLayoutManagerKeyboardTest : public test::AshTestBase {
public:
WorkspaceLayoutManagerKeyboardTest() {}
@@ -983,14 +1009,14 @@ class WorkspaceLayoutManagerKeyboardTest : public test::AshTestBase {
private:
gfx::Insets restore_work_area_insets_;
gfx::Rect keyboard_bounds_;
- WorkspaceLayoutManager *layout_manager_;
+ WorkspaceLayoutManager* layout_manager_;
DISALLOW_COPY_AND_ASSIGN(WorkspaceLayoutManagerKeyboardTest);
};
class FakeTextInputClient : public ui::DummyTextInputClient {
public:
- FakeTextInputClient(gfx::NativeWindow window) : window_(window) {}
+ explicit FakeTextInputClient(gfx::NativeWindow window) : window_(window) {}
virtual ~FakeTextInputClient() {}
virtual gfx::NativeWindow GetAttachedWindow() const OVERRIDE {
« no previous file with comments | « ash/wm/workspace/workspace_layout_manager_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698