Source/core/rendering/RenderObject.h - Issue 337173003: Compute paint invalidation rects for selection in the space of the backing GraphicsLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.h

Issue 337173003: Compute paint invalidation rects for selection in the space of the backing GraphicsLayer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed test expectation. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/squashing/selection-repaint-with-gaps-expected.txt ('k') | Source/core/rendering/RenderSelectionInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index 22bdd386c6b815855846a9895665926a705966d8..758443f1a6ba99a5efde8f5e3a1d0f7e7781dd93 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -821,7 +821,9 @@ public:

LayoutRect boundsRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer) const;

// Actually do the paint invalidate of rect r for this object which has been computed in the coordinate space

- // of paintInvalidationContainer. If paintInvalidationContainer is 0, invalidate paints via the view.

+ // of the GraphicsLayer backing of |paintInvalidationContainer|. Note that this coordinaten space is not the same

+ // as the local coordinate space of |paintInvalidationContainer| in the presence of layer squashing.

+ // If |paintInvalidationContainer| is 0, invalidate paints via the view.

leviw_travelin_and_unemployed 2014/06/17 20:39:02 Please add a FIXME about the null and point it at

void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvalidationContainer, const IntRect&, InvalidationReason) const;

// Invalidate the paint of the entire object. Called when, e.g., the color of a border changes, or when a border