Issue 337173003: Compute paint invalidation rects for selection in the space of the backing GraphicsLayer

Issue 337173003: Compute paint invalidation rects for selection in the space of the backing GraphicsLayer (Closed)

Created:
6 years, 6 months ago by chrishtr

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, ojan

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Compute paint invalidation rects for selection in the space of the backing GraphicsLayer, not the squashing container (they are not the same in the presence of layer squashing). BUG=384963 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176361

Patch Set 1 #

Patch Set 2 : Fixed comment. #

Patch Set 3 : Fix #

Patch Set 4 : Fixed comments. #

Patch Set 5 : Fixed test expectation. #

Total comments: 1

Patch Set 6 : Added comment. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -4 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/compositing/squashing/selection-repaint-with-gaps.html	View	1 2 3	1 chunk	+79 lines, -0 lines	0 comments	Download
A	LayoutTests/compositing/squashing/selection-repaint-with-gaps-expected.txt	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderSelectionInfo.h	View	1 2 3	2 chunks	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

leviw_travelin_and_unemployed

This is sad, but I get it. LGTM :( https://codereview.chromium.org/337173003/diff/80001/Source/core/rendering/RenderObject.h File Source/core/rendering/RenderObject.h (right): https://codereview.chromium.org/337173003/diff/80001/Source/core/rendering/RenderObject.h#newcode826 Source/core/rendering/RenderObject.h:826: ...

6 years, 6 months ago (2014-06-17 20:39:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/337173003/100001

6 years, 6 months ago (2014-06-17 20:49:07 UTC) #4

Message was sent while issue was closed.

Change committed as 176361

Expand Messages | Collapse Messages