Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 337163004: Remove the atomic operations from media::AudioFifo, making it truly thread-unsafe. (Closed)

Created:
6 years, 6 months ago by Alexander Potapenko
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove the atomic operations from media::AudioFifo, making it truly thread-unsafe. This class isn't used in multithreaded fashion anymore. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M media/base/audio_fifo.h View 3 chunks +3 lines, -5 lines 0 comments Download
M media/base/audio_fifo.cc View 4 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
henrika (OOO until Aug 14)
LGTM. Thanks for fixing.
6 years, 6 months ago (2014-06-17 10:51:08 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-17 11:05:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/337163004/1
6 years, 6 months ago (2014-06-17 11:06:02 UTC) #3
Alexander Potapenko
On 2014/06/17 11:06:02, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-17 11:21:47 UTC) #4
Alexander Potapenko
The CQ bit was unchecked by glider@chromium.org
6 years, 6 months ago (2014-06-17 11:21:49 UTC) #5
scherkus (not reviewing)
lgtm
6 years, 6 months ago (2014-06-17 16:19:50 UTC) #6
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-17 16:31:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/337163004/1
6 years, 6 months ago (2014-06-17 16:33:10 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:39:22 UTC) #9
Message was sent while issue was closed.
Change committed as 277796

Powered by Google App Engine
This is Rietveld 408576698