Issue 337163003: Switch to the new SkCanvas::willSave() API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337163003: Switch to the new SkCanvas::willSave() API. (Closed)

Created:
6 years, 6 months ago by f(malita)

Modified:
6 years, 6 months ago

Reviewers:
piman, robertphillips, reed1

CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Switch to the new SkCanvas::willSave() API. Skia's save() SaveFlags bits are deprecated. At this point all callers have been updated to always pass kMatrixClip, but SkCanvas subclasses also need to use the new willSave() API. (depends on https://codereview.chromium.org/338833003/ rolling) BUG=skia:2297 R=piman@chromium.org, reed@google.com, robertphillips@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278363

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	content/renderer/skia_benchmarking_extension_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	skia/ext/analysis_canvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/analysis_canvas.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/ext/benchmarking_canvas.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/337163003/1

6 years, 6 months ago (2014-06-19 12:58:51 UTC) #4

f(malita)

6 years, 6 months ago (2014-06-19 14:39:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r278363 (presubmit successful).