Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 337163002: Check in chrome/app/address_input_strings.grdp. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Check in chrome/app/address_input_strings.grdp. This patch checks in chrome/app/address_input_strings.grdp and does not update it in "gclient runhooks". BUG=327046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278279

Patch Set 1 : #

Patch Set 2 : Do not verify strings in 'gclient runhooks'. #

Patch Set 3 : Update OWNERS. #

Patch Set 4 : Rebase on top of https://codereview.chromium.org/341533004/. #

Patch Set 5 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -1 line) Patch
M chrome/app/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/app/address_input_strings.grdp View 1 1 chunk +254 lines, -0 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/libaddressinput/chromium/tools/update-strings.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
please use gerrit instead
Evan: PTAL Patch Set 1.
6 years, 6 months ago (2014-06-16 16:52:00 UTC) #1
Evan Stade
I wouldn't even bother with the verification script. If it slows down gclient runhooks for ...
6 years, 6 months ago (2014-06-16 16:57:09 UTC) #2
please use gerrit instead
Evan: PTAL Patch Set 2. It does not verify the strings in "gclient runhooks".
6 years, 6 months ago (2014-06-16 17:06:45 UTC) #3
please use gerrit instead
Evan: Might be a good idea to add ourselves to OWNERS for address_input_strings.grd*. If you ...
6 years, 6 months ago (2014-06-16 17:13:59 UTC) #4
Evan Stade
lgtm re: owners, sure
6 years, 6 months ago (2014-06-16 17:50:30 UTC) #5
please use gerrit instead
Carlos: OWNERS PTAL Patch Set 3 - chrome/app/OWNERS - chrome/app/address_input_strings.grdp
6 years, 6 months ago (2014-06-16 17:54:06 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-17 16:31:57 UTC) #7
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-17 16:33:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/337163002/120001
6 years, 6 months ago (2014-06-17 16:34:22 UTC) #9
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 6 months ago (2014-06-17 17:26:32 UTC) #10
please use gerrit instead
James: OWNERS PTAL Patch Set 5: - chrome/tools/build/repack_locales.py
6 years, 6 months ago (2014-06-17 23:33:39 UTC) #11
James Hawkins
lgtm
6 years, 6 months ago (2014-06-17 23:34:38 UTC) #12
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-18 14:33:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/337163002/160001
6 years, 6 months ago (2014-06-18 14:36:21 UTC) #14
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-19 06:21:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/337163002/160001
6 years, 6 months ago (2014-06-19 06:22:47 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 06:28:24 UTC) #17
Message was sent while issue was closed.
Change committed as 278279

Powered by Google App Engine
This is Rietveld 408576698