Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 337123002: Support counter graphs in Timeline based on trace events (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Support counter graphs in Timeline based on trace events BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176228

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M Source/bindings/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/MemoryCountersGraph.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineMemoryOverview.js View 1 2 chunks +4 lines, -8 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 6 months ago (2014-06-16 14:39:18 UTC) #1
caseq
lgtm
6 years, 6 months ago (2014-06-16 15:10:45 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-16 15:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/337123002/20001
6 years, 6 months ago (2014-06-16 15:31:53 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 18:10:40 UTC) #5
Message was sent while issue was closed.
Change committed as 176228

Powered by Google App Engine
This is Rietveld 408576698