QuicServer: Use Chrome's header parsing rather than Balsa

net/spdy/spdy_http_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_HTTP_UTILS_H_
 #define NET_SPDY_SPDY_HTTP_UTILS_H_
 
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
+#include "net/http/http_response_headers.h"

[wtc, 2014/06/25 22:22:25]

A forward declaration of class HttpResponseHeaders should be enough. See my
suggestion on line 33.

[dmziegler, 2014/06/26 01:23:30]

Done.

 #include "net/spdy/spdy_framer.h"
 #include "net/spdy/spdy_header_block.h"
 #include "net/spdy/spdy_protocol.h"
 #include "url/gurl.h"
 
 namespace net {
 
 class HttpResponseInfo;
 struct HttpRequestInfo;
 class HttpRequestHeaders;
 
 // Convert a SpdyHeaderBlock into an HttpResponseInfo.
 // |headers| input parameter with the SpdyHeaderBlock.
 // |response| output parameter for the HttpResponseInfo.
 // Returns true if successfully converted.  False if the SpdyHeaderBlock is
 // incomplete (e.g. missing 'status' or 'version').
 bool SpdyHeadersToHttpResponse(const SpdyHeaderBlock& headers,
                                SpdyMajorVersion protocol_version,
                                HttpResponseInfo* response);
 
-// Create a SpdyHeaderBlock for a Spdy SYN_STREAM Frame from
-// HttpRequestInfo and HttpRequestHeaders.
+// Create a SpdyHeaderBlock from HttpResponseHeaders.
+void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpResponse(

[wtc, 2014/06/25 22:22:25]

1. Put NET_EXPORT_PRIVATE before the return type (void).

Also fix line 38.

2. Nit: it seems nicer to list the *FromHttpResponse function after the
*FromHttpRequest, to match the time line (request, then response).

[dmziegler, 2014/06/26 01:23:30]

Done.

+    scoped_refptr<HttpResponseHeaders> response_headers,

[wtc, 2014/06/25 22:22:25]

Change this to
   const HttpResponseHeaders& response_headers,

Passing a scoped_refptr parameter implies transferring a reference to the
method.

[dmziegler, 2014/06/26 01:23:30]

Done.

+    SpdyMajorVersion protocol_version,
+    SpdyHeaderBlock* headers);
+
+// Create a SpdyHeaderBlock from HttpRequestInfo and HttpRequestHeaders.
 void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpRequest(
     const HttpRequestInfo& info,
     const HttpRequestHeaders& request_headers,
-    SpdyHeaderBlock* headers,
     SpdyMajorVersion protocol_version,
-    bool direct);
+    bool direct,
+    SpdyHeaderBlock* headers);
 
 // Returns the URL associated with the |headers| by assembling the
 // scheme, host and path from the protocol specific keys.
 NET_EXPORT_PRIVATE GURL GetUrlFromHeaderBlock(const SpdyHeaderBlock& headers,
                                               SpdyMajorVersion protocol_version,
                                               bool pushed);
 
 NET_EXPORT_PRIVATE SpdyPriority ConvertRequestPriorityToSpdyPriority(
     RequestPriority priority,
     SpdyMajorVersion protocol_version);
 
 NET_EXPORT_PRIVATE RequestPriority ConvertSpdyPriorityToRequestPriority(
     SpdyPriority priority,
     SpdyMajorVersion protocol_version);
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_HTTP_UTILS_H_